Skip to content

Conversation

@folkertdev
Copy link
Contributor

@folkertdev folkertdev commented Nov 19, 2025

Subtree update of stdarch to rust-lang/stdarch@50134e1.

Created using https://github.com/rust-lang/josh-sync.

The only interesting commit is the final one, which enables the avx10_target_feature feature in the standard library, because it is now used in stdarch.

r? @sayantn (or whoever, this is just a straightforward sync)

folkertdev and others added 29 commits October 27, 2025 00:28
Forward `TEST_SAMPLE_INTRINSICS_PERCENTAGE`
Add intrinsics for the new AMX target features
This updates the rust-version file to 8401398.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: 8401398
Filtered ref: f9e99a8e85fa360f0e820dc75d46cb4583b4300d
Upstream diff: rust-lang/rust@73e6c9e...8401398

This merge was created using https://github.com/rust-lang/josh-sync.
previously the output would just always be all zeroes
Use generic SIMD masked load/stores for avx512 masked load/stores
Use SIMD intrinsics for vector shifts
ARM has withdrawn FEAT_TME
https://developer.arm.com/documentation/102105/lb-05/

LLVM has also dropped support for enabling the feature.
correct some `#[simd_test]` attributes
aarch64: Remove withdrawn FEAT_TME
…dness

correct signedness of pmadd arguments
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2025

stdarch is developed in its own repository. If possible, consider making this change to rust-lang/stdarch instead.

cc @Amanieu, @folkertdev, @sayantn

@rustbot rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Nov 19, 2025
@rustbot

This comment has been minimized.

@folkertdev folkertdev force-pushed the stdarch-sync-2025-11-19 branch from de75473 to ae682a3 Compare November 19, 2025 23:28
@folkertdev folkertdev mentioned this pull request Nov 19, 2025
@folkertdev folkertdev changed the title stdarch subtree update (test) stdarch subtree update Nov 19, 2025
@tgross35
Copy link
Contributor

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Nov 20, 2025

📌 Commit ae682a3 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2025
@Zalathar
Copy link
Member

@bors ping

@bors
Copy link
Collaborator

bors commented Nov 20, 2025

😪 I'm awake I'm awake

@Zalathar
Copy link
Member

Bors, please start running jobs.

@bors retry

bors added a commit that referenced this pull request Nov 20, 2025
stdarch subtree update

Subtree update of `stdarch` to rust-lang/stdarch@50134e1.

Created using https://github.com/rust-lang/josh-sync.

The only interesting commit is the final one, which enables the `avx10_target_feature` feature in the standard library, because it is now used in `stdarch`.

r? `@sayantn` (or whoever, this is just a straightforward sync)
@bors
Copy link
Collaborator

bors commented Nov 20, 2025

⌛ Testing commit ae682a3 with merge 82e8d6a...

@bors
Copy link
Collaborator

bors commented Nov 20, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 20, 2025
@folkertdev
Copy link
Contributor Author

Github won't show me the actual cause, but I think this is just a spurious failure in dist-x86_64-msvc

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2025
@bors
Copy link
Collaborator

bors commented Nov 20, 2025

⌛ Testing commit ae682a3 with merge 2c0f486...

@tgross35
Copy link
Contributor

For reference, you can see what happened if you expand the thing at the top for that job

image

@bors
Copy link
Collaborator

bors commented Nov 20, 2025

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing 2c0f486 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 20, 2025
@bors bors merged commit 2c0f486 into rust-lang:main Nov 20, 2025
12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 20, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 683dd08 (parent) -> 2c0f486 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 2c0f4860cc86e2354a55ea04e738848168435c90 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 14713.9s -> 8168.0s (-44.5%)
  2. dist-aarch64-apple: 7260.7s -> 5728.5s (-21.1%)
  3. x86_64-rust-for-linux: 3068.5s -> 2424.8s (-21.0%)
  4. x86_64-gnu-llvm-20: 2858.2s -> 2314.1s (-19.0%)
  5. x86_64-gnu-llvm-21-2: 5977.4s -> 5125.2s (-14.3%)
  6. aarch64-gnu-llvm-20-2: 2471.2s -> 2175.8s (-12.0%)
  7. x86_64-gnu-tools: 3700.1s -> 3259.0s (-11.9%)
  8. x86_64-gnu-llvm-21-3: 6955.7s -> 6188.3s (-11.0%)
  9. pr-check-1: 1963.5s -> 1754.8s (-10.6%)
  10. dist-x86_64-apple: 7955.4s -> 7182.5s (-9.7%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2c0f486): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.8% [-0.8%, -0.8%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.4%, secondary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
-2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.4% [-2.4%, -2.4%] 1

Cycles

Results (secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.7% [2.8%, 5.0%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.9% [-4.4%, -3.6%] 4
All ❌✅ (primary) - - 0

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.0%] 12
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [0.0%, 0.0%] 12

Bootstrap: 470.773s -> 471.681s (0.19%)
Artifact size: 388.83 MiB -> 388.90 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants